XMPPServerInfo should make a distinction between 'hostname' and 'xmpp domain name'
Description
XMPPServerInfo should report both the XMPP domain identifier of Openfire, as well as the hostname of the local node. Currently, it has just one method, that is confusingly named: #getName().
I would propose to remove the naming confusion as well as to add an additional getter. To do this, the #getName() method can be replaced with two others: #getXmppDomain() and #getHostname(), which return the corresponding identifiers.
To retain backwards compatibility, the old #getName method (and the corresponding #setName()) should not be removed, but marked as 'deprecated'.
Environment
None
Attachments
1
11 Jan 2008, 07:00 PM
Activity
Show:
Guus der Kinderen
January 11, 2008 at 7:00 PM
I have attached a patch that adds the described functionality.
Note that the patch will also make sure that modifying the Date object returned by XMPPServerInfoImpl#getLastStarted() no longer modifies the internal representation of that Date in XMPPServerInfoImpl.
XMPPServerInfo should report both the XMPP domain identifier of Openfire, as well as the hostname of the local node. Currently, it has just one method, that is confusingly named: #getName().
I would propose to remove the naming confusion as well as to add an additional getter. To do this, the #getName() method can be replaced with two others: #getXmppDomain() and #getHostname(), which return the corresponding identifiers.
To retain backwards compatibility, the old #getName method (and the corresponding #setName()) should not be removed, but marked as 'deprecated'.