[#JM-1241] XMPPServerInfo should make a distinction between 'hostname' and 'xmpp domain name'

Openfire

XMPPServerInfo should make a distinction between 'hostname' and 'xmpp domain name'

Created: 01/11/08 04:57 AM Updated: 01/23/08 07:41 PM

Component/s:

Core

Affects Version/s:

None

Fix Version/s:

3.5.0

Time Tracking:

Not Specified

File Attachments:

JM-1241.patch (8 kb)

Support Plan Customer Issue:	No
Resolution Date:	01/23/08 07:10 PM
Acceptance Test - Add?:	No

Description

« Hide

XMPPServerInfo should report both the XMPP domain identifier of Openfire, as well as the hostname of the local node. Currently, it has just one method, that is confusingly named: #getName().

I would propose to remove the naming confusion as well as to add an additional getter. To do this, the #getName() method can be replaced with two others: #getXmppDomain() and #getHostname(), which return the corresponding identifiers.

To retain backwards compatibility, the old #getName method (and the corresponding #setName()) should not be removed, but marked as 'deprecated'.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

Ascending order - Click to sort in descending order

[ Permlink | « Hide ]

Guus der Kinderen - 01/11/08 05:00 AM

I have attached a patch that adds the described functionality.

Note that the patch will also make sure that modifying the Date object returned by XMPPServerInfoImpl#getLastStarted() no longer modifies the internal representation of that Date in XMPPServerInfoImpl.