Issue Details (XML | Word | Printable)

Key: JM-1039
Type: Improvement Improvement
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Gaston Dombiak
Reporter: Matt Tucker
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Openfire (ARCHIVED)

Pluginmanager improvements

Created: 04/24/07 01:45 AM   Updated: 11/21/08 06:55 AM
Component/s: Plugins
Affects Version/s: 3.3.0
Fix Version/s: 3.6.2

Time Tracking:
Not Specified

File Attachments: 1. Text File PluginManager.patch (4 kB)


Support Plan Customer Issue: No
Resolution Date: 11/17/08 08:53 AM
Acceptance Test - Add?: No


 Description  « Hide
Incorporate the attached plugin manager patch. From aznidin:

"With the existing code, a parent plugin's destroyPlugin() is called more than once, addition of which is caused by the number of children plugins. It's the side effect of recursion. The key point is to call parentPluginMap.remove() and childPluginMap.remove() first before recursing the unloadPlugin().

Also, I've added some more codes into PluginManager.java for proper PluginListener implementation. Still a recursion effect and the order of plugins destroyed, the PluginListener.pluginDestroyed() isn't called whenever it should be. Additional info is provided as source comments. Please see the diff file attached."



 All   Comments   Work Log   Change History      Sort Order: Ascending order - Click to sort in descending order
Gaston Dombiak added a comment - 11/17/08 08:53 AM
Testing of the fix is pending. Code is in SVN now.

wroot added a comment - 11/18/08 12:15 AM
I have tried openfire_2008-11-17 nightly, but it has no affect on my problem with uninstalling the plugins. This happens only on my Windows box. Linux box is working fine with that. Uninstall takes a minute or so. Then it will show that plugin was uninstalled, but it still lists that plugin on the Plugins page as installed. After another few minutes it will finally dissapear. But he folder of such plugin in /openfire/plugins/ will stay until next openfire start. If i try to uninstall another plugin, then suddenly first uninstalled plugin appears on the list again.