This thread is archived
6 Replies Last post: Oct 8, 2004 10:14 PM by Gaston Dombiak  
dsaw   3 posts since
Sep 9, 2004
Currently Being Moderated

Sep 9, 2004 8:28 AM

Escaping HTML for RosterGroups and CustomStatus names.

The latest download (1.4.0) has a bug fix (SMACK - 135) for escaping invalid characters in TO and FROM fields of any packets. Shouldn''t this fix be expanded to escape invalid characters in RosterGroup names and CustomStatus names as well?

Gaston Dombiak Jiver 3,751 posts since
Sep 26, 2001
Currently Being Moderated
Sep 14, 2004 8:20 PM in response to: dsaw
Re: Escaping HTML for RosterGroups and CustomStatus names.

AFAIK, the XMPP spec does not really specify which are the valid set of characters for roster item names. Are you having any problem with the current implementation?

 

Regards,

 

  -- Gato

Gaston Dombiak Jiver 3,751 posts since
Sep 26, 2001
Currently Being Moderated
Sep 21, 2004 7:39 AM in response to: dsaw
Re: Escaping HTML for RosterGroups and CustomStatus names.

Thanks for the fix. I''ll incorporate it for the next release.

 

Thanks,

 

  -- Gato

Chris King   1 posts since
Oct 7, 2004
Currently Being Moderated
Oct 7, 2004 10:44 PM in response to: dsaw
Re: Escaping HTML for RosterGroups and CustomStatus names.

I went ahead and fixed this one issue the other day, unified diffs attached (this also addresses some other potential problems, but includes the fix for RosterPacket).

Attachments:
Gaston Dombiak Jiver 3,751 posts since
Sep 26, 2001
Currently Being Moderated
Oct 8, 2004 10:14 PM in response to: Chris King
Re: Escaping HTML for RosterGroups and CustomStatus names.

Hey Chris,

 

Cool. I''ll take a look at your patch and let you know my feedback.

 

Thanks,

 

  -- Gato

More Like This

  • Retrieving data ...