[Patch] System Tray Tool Tip Text

Spark Spark Dev
1

I assume the tool tip name shouldn’t be hard code, but should instead be Default.APPLICATION_NAME or SparkRes.APP_NAME:

Index: C:/Trevor/Spark/src/java/org/jivesoftware/sparkimpl/plugin/systray/SysTrayPlugi n.java

===================================================================

— C:/Trevor/Spark/src/java/org/jivesoftware/sparkimpl/plugin/systray/SysTrayPlugi n.java (revision 11081)

+++ C:/Trevor/Spark/src/java/org/jivesoftware/sparkimpl/plugin/systray/SysTrayPlugi n.java (working copy)

@@ -137,7 +137,7 @@

try {

  • trayIcon = new TrayIcon(availableIcon.getImage(), “Spark”, null);
  • trayIcon = new TrayIcon(availableIcon.getImage(), Default.getString( Default.APPLICATION_NAME ), null);

trayIcon.setImageAutoSize(true);

trayIcon.addMouseListener(new MouseListener() {

2

Thanks! fixed in 11091

3

Thank you.

4

I have just compiled from svn and this issue is still present, the system tray tool tip text is “APPLICATION_NAME”

Changing the code in SysTrayPlugin.java as recommended fixed it.

5

I could be wrong, but I think I checked the repository to ensure that my patch had been applied and as I recall it was, although it could have been reverted for some reason. I’ll check when I get back to work.

Just to be certain, my patch was to make the tooltip display what was set as APPLICATION_NAME instead of always displaying the text Spark. If that’s what it’s doing then my patch has been applied.

Though I leave it up to the people maintaining the project to choose whether they wish to include my patches or not.

6

It seems that after this patch Spark is just displaying the text APPLICATON_NAME and nothing is set for this string (11093 build). Also, in Windows 7 x64 it shows two icons in systray. One has a tooltip Spark, and the other with APPLICATION_NAME. On 32 bit Win7 it shows only the latter one.

7

Sorry I checked my patch and yes I forgot to copy the getString code. I’ve been copying patches that I think the community might be interested in from my working copy to my copy from your server to make it easier to separate out changes that only I’d be interested in and be able to easily apply patches that are made on your server back into my code.

8

The issue with the APP…NAME showing is already fixed by cstux http://www.igniterealtime.org/issues/browse/SPARK-1081.