Smack - fix for NPE in SASLMechanism.java

Smack Smack Dev
1

I was getting NPE from Base64.encodeBytes(), as response was null.

So in SASLMechanism.java at line 154, I replaced

String authenticationText = Base64.encodeBytes(response,Base64.DONT_BREAK_LINES);
        if(authenticationText.equals("")) {
            authenticationText = "=";
        }

with

String authenticationText = "";
        if( null != response ){
          authenticationText = Base64.encodeBytes(response, Base64.DONT_BREAK_LINES);
        }
        if(authenticationText.equals("")) {
            authenticationText = "=";
        }

and now authentization works.

Ondra Zizka

2

Great to see you provide patches. Would be more convenient if you would attach a diff file for your patch. Then it could be easily applied to a project or attached in JIRA (bug tracking system).

3

Attaching diff.

BTW, to reproduce the bug, try connecting to the jabber.cz server with 3.1.0.
SASL-NPE-patch.diff (865 Bytes)

4

filed - SMACK-264

5

Fixed for trunk version on revision 11256.