Oi Daryl,

Thanks a lot for your contribution. I have one feedback and a proposal.

Feedback:

I think that exposing the last time a user was logged in to any other user may be found as a potential security problem. For internal usages I think that people will love it but may be not for all cases. What do you think about this? May be we can make it configurable from the admin console if that column should appear in the result table?

Proposal:

Many times I heard the request for being able to search by Group and also to show the list of groups a user belongs. Since you are already helping us out with the search plugin.....would you like to include this functionality too?

Obrigado,

  -- Gato

Oh, I misread your fix then. I thought that you were modifying the output that clients would get from a user search but I now see that you were referring to the admin console. In that case we are not risking any information leaking and your patch is just fine (i.e. we can include it to the official release).

My suggestion was regarding the user search that users can do from their XMPP clients. Would you like to help us implement that feature?

BTW, have you signed and faxed the Contributor Agreement?

Thanks,

  -- Gato