6 Replies
Last post:
Jun 22, 2007 1:36 PM by
Pete
For #2 we would have to make a difference between incoming and outgoing calls as for outgoing calls you are "on the phone" even if the remote party did not yet answer. For incoming calls this could be different, i.e. setting the "on the phone" status not until the remote party has answered the call.
I agree its not a big issue. Nevertheless I''ve created feature request PHONE-59 to track it. If it''s important for someone you can voted for it 
Wow! I''m so proud of myself! 
I just fixed my first Spark bug. Here''s a patch which will make spark revert to the previous state when all calls are finished. Its my first patch, so hopefully everything is formatted correctly. I can re-do it if necessary.
Index: C:/Documents and Settings/peted20/My Documents/Eclipse Workspace/spark/src/java/org/jivesoftware/sparkimpl/plugin/phone/PhonePlugin.ja va
===================================================================
--- C:/Documents and Settings/peted20/My Documents/Eclipse Workspace/spark/src/java/org/jivesoftware/sparkimpl/plugin/phone/PhonePlugin.ja va (revision 8500)
+++ C:/Documents and Settings/peted20/My Documents/Eclipse Workspace/spark/src/java/org/jivesoftware/sparkimpl/plugin/phone/PhonePlugin.ja va (working copy)
@@ -238,11 +238,15 @@
}
if (offPhonePresence != null) {
- // Set user to available when all phone calls are hung up.
+ // Set user to previous presence state when all phone calls are hung up.
+ SparkManager.getSessionManager().changePresence(o ffPhonePresence);
+
+ offPhonePresence = null;
+ }else{
+ // If no previous state available, set status to Available
& nbsp; Presence availablePresence = new Presence(Presence.Type.available, "Available", 1, Presence.Mode.available);
-
& nbsp; SparkManager.getSessionManager().changePresence(availablePresence);
-
+
& nbsp; offPhonePresence = null;
}
}
Thanks,
Pete
Message was edited by: peted20
Message was edited by: peted20
Sweet Fix pete. It''s in trunk
Thank You Very Much,
Derek
Thanks Derek, that is awesome! I just downloaded 2.5.4 and its working like a champ